[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] wx-2.9.2: undesired change in behavior of MRU list
From: |
Vadim Zeitlin |
Subject: |
Re: [lmi] wx-2.9.2: undesired change in behavior of MRU list |
Date: |
Fri, 22 Jul 2011 18:16:11 +0200 |
On Fri, 22 Jul 2011 13:19:22 +0200 Václav Slavík <address@hidden> wrote:
VS> On 19 Jul 2011, at 14:37, Vadim Zeitlin wrote:
VS> > 2. Just always call some virtual function when the file from MRU couldn't
VS> > be opened, whether it was because it was not found or some other reason
VS> > (and pass the flag indicating its existence, or not, to this function).
VS> >
VS> > (1) is somewhat simpler while (2) is maximally flexible -- but maybe too
VS> > much so? What do you think?
VS>
VS> It's too much, IMHO. (1) covers the most common case and is easy to
VS> implement, while (2) is more complicated with little benefit.
Just FYI, I've committed the changes to wxWidgets as r68334. Failing to
open an existing file now doesn't result in any extra error message (beyond
those given by the code that actually tried and failed to open it) while
the behaviour when opening the non-existent files from the MRU list is the
same as before by default but can now be customized by overriding the new
virtual wxDocManager::OnMRUFileNotExist() method.
Regards,
VZ