[lmi] wx-2.9.2: undesired change in behavior of MRU list

[Greg Chicares]

In 'illustration_view.cpp', IllustrationView::OnCreate() can return false in
a situation that isn't actually an error--namely, when the user begins to open
a file, and then cancels. With wx-2.9.2, this produces an unwanted effect that
was not observed with earlier versions. To reproduce:
  File | New | Illustration | OK
  File | Save as [any name] | press "Save" button
  Alt-minus | Close
  File | 1 [digit one] | Esc
This messagebox pops up:
  The file 'C:\opt\lmi\eraseme\xyz.ill' couldn't be opened.
  It has been removed from the most recently used files list.
and indeed the file has been removed from the MRU list. No such thing happens
with wx-2.9.0 .

The first time I saw that messagebox, I thought "Oh no--it erased my file".
Of course, it didn't, but I had quite a strong emotional reaction, and I'd
like to spare our users that distress. What's the best way to accomplish that?

I realize that this is a fairly unusual GUI technique: loading a file pops up
a dialog, and the doc-view frame window is created only if OK is pressed. But
there's at least a historical reason for it: pressing OK triggers calculations
that took a considerable amount of time a decade ago on the usual hardware of
that era, and it was handy to hit Cancel if you opened a different file than
you intended to and noticed it right away. That reason is no longer compelling,
but lmi and some other illustration systems still behave this way, and I would
rather not change this fundamental behavior today.