Re: [lmi] sequence input editor -- how to get accepted keywords

[Greg Chicares]

On 2010-06-27 06:52Z, Vaclav Slavik wrote:
> On Sat, 2010-06-26 at 14:13 +0000, Greg Chicares wrote:
>> No. Commenting out each use of wxWindowUpdateLocker fixes it.
> ...
>> No. I see no flicker. Everything looks fine. 
> 
> Good, I just removed it, then. I also fixed 2.9.0 compilation less
> verbosely and added the better gcc warnings fix:
> 
> diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
[...]
> The ReviewBoard topic is updated too (old version that the above diff is
> against is at http://review.bakefile.org/r/210/diff/4/).

Probably it would make sense for me to commit the bulk of this to lmi
svn soon. We've discussed some other things since then, and I don't want
you to feel compelled to maintain a separate tree.

I see that I can commit this while keeping the new facility inaccessible
to end users until we have tested it thoroughly. I'll probably do this
in discrete steps--for instance, first refactoring 'datum_string.hpp'
as discussed in this thread--so that we have a number of rollback points
in case I do something wrong.

For now, I definitely won't change any skin but 'skin.xrc'. That's my
"personal" UI, which end users don't use. This means we'll be able to
test everything thoroughly before it becomes active in production, even
though it'll be in the production system. I believe this will be quite
safe because the real complexity is in 'input_sequence_entry.?pp', which
is easily walled off by not using its class in any production skin. The
other changes seem to be straightforward enough that careful integration
should suffice to prevent mistakes.