lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] change file formats to XML


From: Greg Chicares
Subject: Re: [lmi] change file formats to XML
Date: Mon, 08 Mar 2010 14:07:26 +0000
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

On 2010-02-26 14:56Z, Vaclav Slavik wrote:
> 
> I uploaded the XML file formats patch to Savannah:
> 
>    https://savannah.nongnu.org/patch/index.php?7101

'xml_lmi_fwd.hpp' distinguishes elements from nodes:

    /// XMLWRAPP !! It is useful to distinguish elements from DOM
    /// nodes that are not elements; xmlwrapp doesn't make this
    /// distinction, but a future replacement might.
    typedef xml::node element;

In 'stratified_charges.hpp', the above patch distinguishes them here:

    void read       (xml::element const& node);
    void write      (xml::node&) const;

but not in the same way here:

    void read_entity (xml::element const& node, e_stratified);
    void write_entity(xml::element& node, e_stratified) const;

However, 'streamable.hpp' doesn't distinguish them in that way:

    virtual void read (xml::element const&) = 0;
    virtual void write(xml::element&) const = 0;

Assuming we want to make the distinction at all, wouldn't it be
more precise to use xml::element in all these (and similar) cases?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]