lmi
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Wrong wxFlexGridSizer usage in about_dialog.cpp

From: Greg Chicares
Subject: Re: [lmi] Wrong wxFlexGridSizer usage in about_dialog.cpp
Date: Wed, 13 Jan 2010 18:17:34 +0000
User-agent: Thunderbird 2.0.0.23 (Windows/20090812) 
On 2010-01-13 13:45Z, Greg Chicares wrote:
> 
> [...]At 1600x1200 resolution, OTOH, the
> window is only about half as high as it "wants" to be, so the inability
> to resize it feels like a defect.
> 
> This is the first thing a new user sees when running the program for the
> first time, so I'm concerned about first impressions.

And what about the eighty-column width, e.g. at 1600x1200, where the GPL
looks like a lone column in a newspaper? We could apply the patch below [0]
to format the license as html paragraphs (instead of wrapping the raw
eighty-column text in 'pre' tags), and then set both height and width to
occupy the whole screen.

---------

[0] "the patch below" [`rm quoted_gpl_html`, then rebuild with this]

Index: text_to_html_strings.sed
===================================================================
--- text_to_html_strings.sed    (revision 4734)
+++ text_to_html_strings.sed    (working copy)
@@ -35,11 +35,13 @@
 s|<|\&lt;|g
 s|>|\&gt;|g

-# Replace formfeed with CSS2 page break, closing and then reopening
-# the <pre> section that encloses the transformed input because <div>
-# cannot appear in a <pre> section.
-s|\f|<\/pre><div style="page-break-before:always"><\/div><pre>|
+# Expunge formfeeds; insert paragraph tags.
+s|\f||g
+s|^$|</p>\n\n<p>\n|

+# Do not pretend that '`' is a left single quote.
+s|`|'|g
+
 # Add a generic html header and footer. Implementation notes:
 #
 # The header and footer must be quoted for use as C strings. It seems
@@ -73,10 +75,10 @@
 1s|\a|\n<title></title>\a|
 1s|\a|\n</head>\a|
 1s|\a|\n<body>\a|
-1s|\a|\n<pre>\a|
+1s|\a|\n<p>\a|
 1s|\a|\n|
 # Add generic footer.
-$s|$|\n</pre>|
+$s|$|\n</p>|
 $s|$|\n</body>|
 $s|$|\n</html>|
reply via email to
[Prev in Thread] Current Thread [Next in Thread]