lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] a TODO Marker: move "PolicyYear" into Effective Calculation Summar


From: Evgeniy Tarassov
Subject: [lmi] a TODO Marker: move "PolicyYear" into Effective Calculation Summary columns list
Date: Mon, 20 Nov 2006 15:25:33 +0100

A TODO mark in the code:
http://cvs.savannah.nongnu.org/viewcvs/lmi/ledger_xml_io2.cpp?rev=1.3.2.1&root=lmi&only_with_tag=branch-20061115&view=markup
|    // TODO ?? CALCULATION_SUMMARY EVGENIY--I think it would be better
|    // to move this to 'configurable_settings.cpp', perhaps adding it
|    // to effective_calculation_summary_columns(); would that work?
|    std::vector<value_id> required_columns;
|    required_columns.push_back(value_id::from_name("PolicyYear"));
|    formatter.add_columns_to_format(required_columns);

Moving "PolicyYear" column into effective_calculation_summary_columns like so:

--- configurable_settings.cpp   2006-11-14 05:35:27.000000000 +0100
+++ configurable_settings.mine.cpp      2006-11-20 15:21:23.296875000 +0100
@@ -401,10 +401,12 @@
std::string const& effective_calculation_summary_columns()
{
    configurable_settings const& z = configurable_settings::instance();
-    return
-        z.use_builtin_calculation_summary()
-        ? default_calculation_summary_columns()
-        : z.calculation_summary_columns()
-        ;
+    static std::string columns;
+    columns = z.use_builtin_calculation_summary()
+              ? default_calculation_summary_columns()
+              : z.calculation_summary_columns()
+              ;
+    columns = "PolicyYear " + columns;
+    return columns;
}

would work, but will need some modifications to lmi *.xsl resources,
which do not appear in the current working branch_20061115.
Greg--do you want me to send a patch to the mailing list, or to apply
the modifications in the gnome-xml-branch?

Evgeniy




reply via email to

[Prev in Thread] Current Thread [Next in Thread]