[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master b719340 09/12: Reword
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master b719340 09/12: Reword |
Date: |
Mon, 28 Jun 2021 18:44:28 -0400 (EDT) |
branch: master
commit b719340b713ccb3c0bd4dbe2d7ce93c540e19f84
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Reword
---
test_coding_rules.cpp | 8 ++++----
test_coding_rules_test.sh | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/test_coding_rules.cpp b/test_coding_rules.cpp
index f2582b1..2fc1652 100644
--- a/test_coding_rules.cpp
+++ b/test_coding_rules.cpp
@@ -783,14 +783,14 @@ void check_include_guards(file const& f)
,boost::regex(R"(\.hpp$)")
,"_hpp"
);
- std::string const guard_start =
+ std::string const opening_guard =
R"(\n#ifndef )" + guard
+ R"(\n#define )" + guard + R"(\n)"
;
- std::string const guard_end = R"(\n#endif // )" + guard + R"(\n+$)";
+ std::string const closing_guard = R"(\n#endif // )" + guard + R"(\n+$)";
- require(f, guard_start, "lacks start part of the canonical header guard.");
- require(f, guard_end, "lacks end part of the canonical header guard.");
+ require(f, opening_guard, "lacks canonical opening header guard.");
+ require(f, closing_guard, "lacks canonical closing header guard.");
}
void check_inclusion_order(file const& f)
diff --git a/test_coding_rules_test.sh b/test_coding_rules_test.sh
index 4ed93cc..3f13e82 100755
--- a/test_coding_rules_test.sh
+++ b/test_coding_rules_test.sh
@@ -443,10 +443,10 @@ File 'eraseme_cpp_007.cpp' spurious or malformed
for-range-declaration: 'for (au
File 'eraseme_cpp_007.cpp' should have a space on both sides of the colon
following the for-range-declaration, instead of ': '.
File 'eraseme_cpp_007.cpp' for-range-declaration should deduce type rather
than specify 'int'.
File 'eraseme_cpp_007.cpp' for-range-declaration should use 'auto&' or 'auto
const&' instead of 'auto '.
-File 'eraseme_hpp_001.hpp' lacks end part of the canonical header guard.
-File 'eraseme_hpp_002.hpp' lacks start part of the canonical header guard.
-File 'eraseme_hpp_003.hpp' lacks start part of the canonical header guard.
-File 'eraseme_hpp_004.hpp' lacks end part of the canonical header guard.
+File 'eraseme_hpp_001.hpp' lacks canonical closing header guard.
+File 'eraseme_hpp_002.hpp' lacks canonical opening header guard.
+File 'eraseme_hpp_003.hpp' lacks canonical opening header guard.
+File 'eraseme_hpp_004.hpp' lacks canonical closing header guard.
File 'eraseme_hpp_005.hpp' must include 'config.hpp' first.
File 'eraseme_hpp_006.hpp' must include 'config.hpp'.
File 'eraseme_hpp_006.hpp' lacks line '#include "config.hpp"'.
- [lmi-commits] [lmi] master updated (016bf00 -> 04ec593), Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master d90e9fb 01/12: Ensure that test_coding_rules exits with failure on any error, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 8882ef7 07/12: Use contains() for the lmi URL check, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 07edbd8 10/12: Document the One True nonempty d-char-sequence, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 4bcdbdb 11/12: Make a test more stringent, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 30ba88a 02/12: Remove check for Latin-9 from coding rules test, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 0f1bc07 03/12: Split the check for canonical header guards in two parts, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master c1edfef 04/12: Use more standard regex syntax in the raw C++11 strings check, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 81c56f8 05/12: Add a test for detecting mis-sorted #include directives, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 72a9f51 06/12: Add a test for for-range declaration coding style checks, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master b719340 09/12: Reword,
Greg Chicares <=
- [lmi-commits] [lmi] master a9bc62f 08/12: Count coding-rules complaints, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 04ec593 12/12: Make another test more stringent, Greg Chicares, 2021/06/28