[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 8882ef7 07/12: Use contains() for the lmi URL
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 8882ef7 07/12: Use contains() for the lmi URL check |
Date: |
Mon, 28 Jun 2021 18:44:28 -0400 (EDT) |
branch: master
commit 8882ef78686f6075db878a8ff7a5944275281ac9
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Use contains() for the lmi URL check
This is simpler, more correct (because periods in the regex would need
to be escaped, making it less readable, to really match just this URL)
and much faster (by a factor of ≈50).
---
test_coding_rules.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test_coding_rules.cpp b/test_coding_rules.cpp
index 4d345df..7d1e8f6 100644
--- a/test_coding_rules.cpp
+++ b/test_coding_rules.cpp
@@ -910,8 +910,10 @@ void check_preamble(file const& f)
return;
}
- static std::string const url("https://savannah.nongnu.org/projects/lmi");
- require(f, url, "lacks lmi URL.");
+ if(!contains(f.data(), "https://savannah.nongnu.org/projects/lmi"))
+ {
+ complain(f, "lacks lmi URL.");
+ }
}
/// Deem a reserved name permissible or not.
- [lmi-commits] [lmi] master updated (016bf00 -> 04ec593), Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master d90e9fb 01/12: Ensure that test_coding_rules exits with failure on any error, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 8882ef7 07/12: Use contains() for the lmi URL check,
Greg Chicares <=
- [lmi-commits] [lmi] master 07edbd8 10/12: Document the One True nonempty d-char-sequence, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 4bcdbdb 11/12: Make a test more stringent, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 30ba88a 02/12: Remove check for Latin-9 from coding rules test, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 0f1bc07 03/12: Split the check for canonical header guards in two parts, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master c1edfef 04/12: Use more standard regex syntax in the raw C++11 strings check, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 81c56f8 05/12: Add a test for detecting mis-sorted #include directives, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 72a9f51 06/12: Add a test for for-range declaration coding style checks, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master b719340 09/12: Reword, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master a9bc62f 08/12: Count coding-rules complaints, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 04ec593 12/12: Make another test more stringent, Greg Chicares, 2021/06/28