Re: Unwanted barree finger in fret diagram

[Thomas Morley]

2015-09-08 12:08 GMT+02:00 Phil Holmes <address@hidden>:
> This is closer to minimal to illustrate the issue:

or even:

\markup { \fret-diagram #"1-0;" } %% unwanted output

\markup { \fret-diagram #"1-o;" }

>
> You are using zero, for example "6-0".  If you check the manuals you will
> see they use the letter o: "6-o"
>
> --
> Phil Holmes



Already pushed is (available 2.19.27):

commit e2e1656c9d0897fb45a215bdcb96b146100c33e2
Author: Thomas Morley <address@hidden>
Date:   Sun Aug 23 15:24:06 2015 +0200

    Clear fret-diagram- and harp-pedal-input-strings from whitespace

    issue 4575

    Whitespace-characters are deleted before further processing.

    Allows for
    \markup \fret-diagram #"s:2;h:5;
    6-3;5-5;4-5;3-4;2-3;1-x;"

    Also adding errors for typos in fret-diagram with a meaningful message:
    \markup \fret-diagram #"s:2;g:r;
    6-3;5-5;4-5;3-4;2-3;1-x;"
    will return:
    fatal error: Unhandled entry in fret-diagram "g:r" in "g:r"

    This error would not apply, if something for #\g would be defined
    in fret-parse-definition-string somewhere in the future.

    Then, the message would be:
    fatal error: Unhandled entry in fret-diagram "r" in "g:r"

    Something similiar is already in harp-pedals.scm


I.e. his patch will also throw errors for bad input-strings, but it
would not have triggered by the use case above.

Do we want
\markup { \fret-diagram #"1-0;" } %% unwanted output
keep working?
I can't imagine a use-case right now.

If not, a follow up patch, maybe returning a warning, would probably
be possible.


Cheers,
  Harm