Re: rendering differences if using `-j12 CPU_COUNT=12`

[Jean Abou Samra]

Le 01/05/2021 à 08:50, Werner LEMBERG a écrit :

> Folks,
>
>
> since some weeks I encounter a very strange problem while compiling
> git HEAD.  I get different rendering results for
>
>    make doc
>
> vs.
>
>    make doc -j12 CPU_COUNT=12
>
> as the attached `1-*.png` images show: in most cases, the glyph
> `accidentals.sharp` in the `-j12` build is replaced with
> `accidentals.sharp.slashslashlslash.stem` if rendered in markups.
>
> However, there is also a file where apparently the `-j12` build is
> correct, see `2-*.png`.  On the other hand, if I compile the affected
> file manually (the first example in the NR section 'Music notation
> inside markup'), everything's fine.
>
> This happens reliably with my setup.  I didn't observe this earlier
> since my old laptop didn't have 12 CPUs.  However, I can't say with
> full confidence that it didn't happen.
>
> Does anyone else see this, or maybe a similar problem?  Unfortunately,
> I have no clue how to tackle the issue.  Any ideas?

Interesting. This is the same kind of cross-file
bleedover that we have seen a few times. Since
commit 4751d0a66e97a61c763c150bb38f0446cc945f4d,
ly/turkish-makam.ly contains this:

#(set! standard-alteration-glyph-name-alist
       (append turkishMakamGlyphs
               standard-alteration-glyph-name-alist))


which changes the shared variable
standard-alteration-glyph-name-alist, used by the
\sharp markup command among others.

(define-markup-command (sharp layout props)
  ()
  #:category music
  "Draw a sharp symbol.

@lilypond[verbatim,quote]
\\markup {
  \\sharp
}
@end lilypond"
  (interpret-markup layout props
                    (make-musicglyph-markup
                     (assoc-get 1/2 
standard-alteration-glyph-name-alist ""))))

This means that if a snippet using turkish-makam.ly
is compiled, in the same session, before a file
using \markup \sharp, the glyph changes.

Basically the mechanism should be changed so that
set! is no longer needed.

Best,
Jean