Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden)

[jonas . hahnfeld]

https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc
File lily/freetype.cc (right):

https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc#newcode143
lily/freetype.cc:143: };
Not sure if FT developers plan to change this interface at some point.
In other projects, I have seen something akin to
FT_Outline_Funcs funcs;
memset(&funcs, 0, sizeof(funcs));
for external structs from dependencies to make sure no field goes
uninitialized.

https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc#newcode149
lily/freetype.cc:149: return ((Path_interpreter *) user)->moveto (*to);
Do you want to create copies of the arguments? (here and for the other
functions)

https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc#newcode172
lily/freetype.cc:172: printf (" glyph %ld ", signed_idx);
debug?

https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc#newcode188
lily/freetype.cc:188: interpreter.transform_ = transform;
create constructor for Path_interpreter?

https://codereview.appspot.com/566080043/