Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by address@hidden)

[lemzwerg]

Thanks for the changes.  Here the next round of comments :-)


https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc
File lily/open-type-font-scheme.cc (right):

https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode467
lily/open-type-font-scheme.cc:467: warning (_f ("font index %d too large
for font `%s', using index 0",
Maybe it makes sense to use a format like

  font `%s': ...

here, too.

https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode495
lily/open-type-font-scheme.cc:495: warning (_f ("font `%s': cannot read
`%s' field of subfont %d",
Shall we do

  s/`%s' field/field `%s'/

here and in the following messages?  Ditto

  s/`%s' table/table `%s'/

later on.  We already have `font xxx' and `subfont yyy'...

https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode513
lily/open-type-font-scheme.cc:513: warning (_f ("font `%s': cannot open
for writing",
Shall we replace `font' with `subfont' here and in succeeding write
messages?

https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode594
lily/open-type-font-scheme.cc:594: " table no. %u of subfont %d",
s/table no. %u/table %u/

https://codereview.appspot.com/548080043/