[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by addr
|
From: |
trueroad |
|
Subject: |
Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by address@hidden) |
|
Date: |
Sun, 03 May 2020 19:33:26 -0700 |
Thank you for your reviewing.
https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely
File Documentation/usage/running.itely (right):
https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely#newcode663
Documentation/usage/running.itely:663: this method cannnot embed CID
fonts with Ghostscript 9.26 and later.
On 2020/05/03 15:20:16, lemzwerg wrote:
> s/cannnot/cannot/
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc
File lily/open-type-font-scheme.cc (right):
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode421
lily/open-type-font-scheme.cc:421: "ttcTag", collection.c_str ()));
On 2020/05/03 15:20:17, lemzwerg wrote:
> Why "ttcTag"? I would rather call this "TTC tag".
The TTC Header Version 1.0 and 2.0 tables of `4.6.3 TTC header' in
`ISO/IEC 14496-22 Open Font Format' names it "ttcTag" instead of "TTC
tag".
Also, `TTC Header'
https://docs.microsoft.com/en-us/typography/opentype/spec/otff#ttc-header
in `OpenType specification version 1.8.3'
https://docs.microsoft.com/en-us/typography/opentype/spec/
uses "ttcTag" instead of "TTC tag".
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode428
lily/open-type-font-scheme.cc:428: warning (_f ("font file `%s' is not
collection font",
On 2020/05/03 15:20:16, lemzwerg wrote:
> s/not collection font/not a font collection/
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode437
lily/open-type-font-scheme.cc:437: warning (_f ("cannot read %s of
`%s'",
On 2020/05/03 15:20:17, lemzwerg wrote:
> font `%s': cannot read `Version' field
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode446
lily/open-type-font-scheme.cc:446: warning (_f ("font file `%s' TTC
header version is unknown",
On 2020/05/03 15:20:17, lemzwerg wrote:
> → ... `%s': invalid TTC header version
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode455
lily/open-type-font-scheme.cc:455: warning (_f ("cannot read %s of
`%s'",
On 2020/05/03 15:20:17, lemzwerg wrote:
> font `%s': cannot read `numFonts' field
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode478
lily/open-type-font-scheme.cc:478: warning (_f ("cannot read %s of
`%s'",
On 2020/05/03 15:20:17, lemzwerg wrote:
> font `%s': cannot read offset of subfont %d
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode495
lily/open-type-font-scheme.cc:495: warning (_f ("cannot read %s of
`%s'",
On 2020/05/03 15:20:16, lemzwerg wrote:
> → font `%s': cannot read `sfntVersion' field of subfont %d
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode504
lily/open-type-font-scheme.cc:504: warning (_f ("font file `%s' index %d
does not have valid sfntVersion",
On 2020/05/03 15:20:17, lemzwerg wrote:
> font `%s': invalid `sfntVersion' field in subfont %d
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode513
lily/open-type-font-scheme.cc:513: warning (_f ("cannot open font
filename `%s'",
On 2020/05/03 15:20:17, lemzwerg wrote:
> → cannot open font `%s' for writing
Done.
https://codereview.appspot.com/548080043/diff/573790043/lily/open-type-font-scheme.cc#newcode523
lily/open-type-font-scheme.cc:523: warning (_f ("cannot write %s of
`%s'",
On 2020/05/03 15:20:17, lemzwerg wrote:
> font `%s': cannot write `sfntVersion' field
>
> etc., etc. for remaining messages
Done.
https://codereview.appspot.com/548080043/