[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563
From: |
nine . fierce . ballads |
Subject: |
Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden) |
Date: |
Tue, 28 Jan 2020 16:06:13 -0800 |
Reviewers: ,
Description:
https://sourceforge.net/p/testlilyissues/issues/5707/
These tests are failing in master @
2ccac23c0e9f7528e55dfd8d711420b4bc5d7a43.
I assume they have been failing for some time.
1: fix bug in display of \cueDuring and \quoteDuring
I'm not at all certain that I've fixed this the right way.
Should the test case be changed instead?
Is there a third option?
2: treat warnings as errors in display-lily-tests.ly
so that bugs will not be overlooked.
Please review this at https://codereview.appspot.com/563430046/
Affected files (+3, -2 lines):
M input/regression/display-lily-tests.ly
M scm/define-music-display-methods.scm
Index: input/regression/display-lily-tests.ly
diff --git a/input/regression/display-lily-tests.ly
b/input/regression/display-lily-tests.ly
index
215f130ea788c38a3e0923172d8ff8290b92df75..044fdde922b18e1ddc3af2fcb05bdb12005b28d1
100644
--- a/input/regression/display-lily-tests.ly
+++ b/input/regression/display-lily-tests.ly
@@ -22,6 +22,7 @@
(cons input-str result-str))))
#(read-hash-extend #\[ parse-lily-and-compute-lily-string) %{ ] %}
+#(ly:set-option 'warning-as-error #t)
test =
#(define-void-function (harmless strings)
Index: scm/define-music-display-methods.scm
diff --git a/scm/define-music-display-methods.scm
b/scm/define-music-display-methods.scm
index
7bdb757f34ddcacc91952a0db5df144183ffdcee..3516286c17def21193ce9074a17433e2b2171bb1
100644
--- a/scm/define-music-display-methods.scm
+++ b/scm/define-music-display-methods.scm
@@ -1078,11 +1078,11 @@ Otherwise, return #f."
quoted-context-id "cue"
quoted-context-type 'CueVoice
element ?music))
- (format #f "\\cueDuring #~s #~a ~a"
+ (format #f "\\cueDuring ~s #~a ~a"
?quoted-music-name
?quoted-voice-direction
(music->lily-string ?music)))
- (format #f "\\quoteDuring #~s ~a"
+ (format #f "\\quoteDuring ~s ~a"
(ly:music-property expr 'quoted-music-name)
(music->lily-string (ly:music-property expr 'element)))))
- Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden),
nine . fierce . ballads <=
- Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden), nine . fierce . ballads, 2020/01/28
- Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden), dak, 2020/01/28
- Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden), nine . fierce . ballads, 2020/01/28
- Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden), dak, 2020/01/29
- Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by address@hidden), nine . fierce . ballads, 2020/01/29