lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 4550: Avoid "using namespace std; " in included files (Take 2)


From: Dan Eble
Subject: Re: Issue 4550: Avoid "using namespace std; " in included files (Take 2) (issue 579240043 by address@hidden)
Date: Sat, 25 Jan 2020 08:14:50 -0500

On Jan 25, 2020, at 07:26, David Kastrup <address@hidden> wrote:
> 
> -      Interval hex = head->extent (common_[X_AXIS], X_AXIS);
> +      Interval head_ext = head->extent (common_[X_AXIS], X_AXIS);
...
> 
> That last part applies part of a patch from an unrelated issue of
> Han-Wen.  Please don't do stuff like that, if necessary using

It does not apply a patch from Han-Wen.  It necessarily renames that variable 
prior to a scripted replacement of "hex" with "std::hex".  I wonder whether the 
task would have been easier if I had used a different name for the variable.

> Please don't do stuff like that, if necessary using
> 
> git reset --hard

I don't understand from this description exactly problem you experienced and 
where in my development process you would have wanted me to use that command.
— 
Dan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]