Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

[Thomas Morley]

Am Mi., 22. Jan. 2020 um 00:59 Uhr schrieb David Kastrup <address@hidden>:
>
> Thomas Morley <address@hidden> writes:
>
> > Hi,
> >
> > some remarks:
> >
> > Guile-3.0
> > First I compiled successfully guile-master from their repo, giving GNU
> > Guile 3.0.0.6-f3298
> > Trying to compile LilyPond with that guile (ofcourse adding a bunch of
> > patches) I had some problems pointing configure to the correct guile
> > and guile-config to the correct places. This was due to my setup with
> > too many guile-versions around. So I did some clean up.
> >
> > LilyPond
> > Afterwards I've got a successful ´make´ with current LilyPond-master.
> > ´make LANGS='' doc´ failed, though.
> >
> > The problem is /input/regression/context-defaultchild-cycle.ly
> > I do not understand how this regtest survives any compilation.
> > It contains
> > #(ly:set-option 'warning-as-error #t)
> > and some
> > #(ly:expect-warning ...)
> > If I compile it, separetly I always get warnings (after disabling
> > 'warning-as-error )
> > warning: default child context begins a cycle: Score
> > warning: cannot find or create context: Bottom
> > warning: default child context begins a cycle: Score
> > warning: cannot find or create context: Bottom
> > warning: 4 expected warning(s) not encountered:
> >         default child context begins a cycle: `Score'
> >         cannot find or create new `Bottom'
> >         default child context begins a cycle: `Score'
> >         cannot find or create new `Bottom'
> >
> > As far as I understand it errors always.
>
> commit 51b6513eeeaea69293bd4f554f8021529ae85a49
> Author: Dan Eble <address@hidden>
> Date:   Mon Jul 2 13:36:48 2018 -0400
>
>     Issue 5366: Move warnings out of find/create context functions
>
>     The motivation for this is that Context::find_create_context () and
>     find_context_near () should probably be merged for maintainability,
>     but one of the differences between them that must be dealt with is
>     that find_create_context () logs when it fails and find_context_near
>     () does not.  Adding warnings to find_context_near () risks being too
>     noisy, leaving the option taken here.
>
>     The new method Context::diagnostic_id (name, id) returns a formatted
>     string (e.g. "Voice" or "Voice = mel") for use in a log message.  It
>     is used for the warnings that are being moved as well as a few other
>     existing warnings to increase consistency.
>
> diff --git a/input/regression/context-defaultchild-cycle.ly 
> b/input/regression/context-defaultchild-cycle.ly
> index f62532f8bb..46de604dfd 100644
> --- a/input/regression/context-defaultchild-cycle.ly
> +++ b/input/regression/context-defaultchild-cycle.ly
> @@ -2,10 +2,10 @@
>
>  #(ly:set-option 'warning-as-error #t)
>  %% not sure why these warnings appear twice [dfe]
> -#(ly:expect-warning (_ "default child context begins a cycle: `~a'") 'Score)
> -#(ly:expect-warning (_ "cannot find or create new `~a'") 'Bottom)
> -#(ly:expect-warning (_ "default child context begins a cycle: `~a'") 'Score)
> -#(ly:expect-warning (_ "cannot find or create new `~a'") 'Bottom)
> +#(ly:expect-warning (_ "default child context begins a cycle: ~a") 'Score)
> +#(ly:expect-warning (_ "cannot find or create context: ~a") 'Bottom)
> +#(ly:expect-warning (_ "default child context begins a cycle: ~a") 'Score)
> +#(ly:expect-warning (_ "cannot find or create context: ~a") 'Bottom)
>
>  \header {
>    texidoc = "A @code{\\defaultchild} cycle does not induce an endless loop.

Got it, many thanks

>
> So why is that patch not in your
> input/regression/context-defaultchild-cycle ?

Obviously I patched this regtest (to reflect new guile-3 shortcut of
gettext), _before_ Dan corrected it.
And prefered my patch during solving the merge-conflict, without
noticing the correction.

Thanks,
  Harm