Re: Cleanup initialization of configure process (issue 549350043 by address@hidden)

[dak]

On 2020/01/08 20:30:20, hahnjo wrote:
> On 2020/01/08 20:14:20, dak wrote:
> > On 2020/01/08 19:49:22, hahnjo wrote:
> > > On 2020/01/08 19:40:06, c_sorensen wrote:
> > > > How about
> > > >
> > > > AC_INIT([LilyPond],m4_esyscmd(echo `VERSION.AC'))
> > > >
> > > > The documentation says it is permissible to use m4_esyscmd as
part of the
> > > > package information strings in AC_INIT.
> > > >
> > > > Carl
> > >
> > > Not quite, but a variation seems to work. However I find this so
ugly that
> I'm
> > > not willing to pursue this direction. The documentation says
AC_INIT should
> be
> > > called with constant arguments, and we're again trying to find
ways around
> it
> > > :-(
> >
> > With that invocation, m4_esyscmd is called before AC_INIT is
replaced so it
> _is_
> > being called with a constant argument.  It turns out that m4_include
would be
> > the much more sane variant with this usage, but with m4_esyscmd we
can
> actually
> > write:
> >
> > # Bootstrap the init process.
> > AC_INIT([LilyPond], m4_esyscmd([. ./VERSION;echo -n
> > ${MAJOR_VERSION}.${MINOR_VERSION}.${PATCH_LEVEL}]),
> > mailto:[address@hidden], [lilypond], [http://lilypond.org/])
> >
> > and there is no need to futz with autogen.sh or anything else.

> Oh, this actually looks pretty ok :O

The problematic question is whether ./ is the right source directory in
all questions or whether there is something else we'd need to use.  The
code in autogen.sh for a readonly source directory would not work.  I
doubt anyone uses it, but it could be made to copy the VERSION file
maybe?  I don't see any other simple expedient right now.

> On 2020/01/08 20:15:10, c_sorensen wrote:
> > What documentation says AC_INIT should be called with constant
arguments?

> looks like I confused / misunderstood some other page...



https://codereview.appspot.com/549350043/