lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] Issue 3411 in lilypond: Patch: Mostly cosmetic simplific


From: lilypond
Subject: [Lilypond-auto] Issue 3411 in lilypond: Patch: Mostly cosmetic simplifications in woodwind diagrams and library
Date: Thu, 13 Jun 2013 14:47:21 +0000

Status: Started
Owner: ----
Labels: Type-Enhancement Patch-new

New issue 3411 by address@hidden: Patch: Mostly cosmetic simplifications in woodwind diagrams and library
http://code.google.com/p/lilypond/issues/detail?id=3411

Mostly cosmetic simplifications in woodwind diagrams and library

The woodwind stuff really needs to get rewritten.  It is a topsy-turvy
contraption where lists are almost but not quite evaluated, lots of
oversweeping functionality is defined but not documented and then
applied in a manner that can be called nothing but ridiculous.

For example, there are "mapping" hooks that only ever return their old
value or a constant.  There are O(n m) functions for accessing
selected keys from a list which are then called with the complete list
of keys itself.  There is wagonloads of quasiquoting and list juggling
going on which might likely better be replaced with inline code.

There is no rhyme nor reason behind which functions are made public
and which are moved into lily-library.

This patch touches at best a few superficial points.  It was more
intended as a library cleanup but got drawn into the woodwinds as one
of the callers of stuff.

http://codereview.appspot.com/10265043

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]