[Klog-devel] [Fwd: [Klog-svn] r35 - trunk/src]

[Jaime Robles]

Good morning (here).

Just a quick comment regarding the logs...

I still have not tested this R35 update but I don't agree to remove the
"if" statements as it will (as you already said) increase the logfile with
no useful information.

Reading the logfile will be a longer process as it will have to read ALL
the tags.
ADIF files are sometime edited by the user with a text editor... we should
keep them easy to read/understand.

The specification[1] does not forbid what you are proposing but I think it
would not be a best practice.
If you think that we should improve the writting speed... IMHO we should
think how to optimize the function but keeping the log short and concise,
with all the needed data but simple and "good looking" :-)

Regarding the TODO... maybe we should manage this in the TODO file, or
maybe using a bug tracker... I think Berlios offers one.


[1] http://www.adif.org/adif223.htm



-- 
Un saludo,
        Jaime Robles, EA4TV
        address@hidden

Visita:
   http://jaime.robles.es

---------------------------- Mensaje original ----------------------------
Asunto: [Klog-svn] r35 - trunk/src
De:     "agoldie at BerliOS" <address@hidden>
Fecha:  Mie, 30 de Septiembre de 2009, 10:11 am
Para:   address@hidden
--------------------------------------------------------------------------

Author: agoldie
Date: 2009-09-30 10:11:16 +0200 (Wed, 30 Sep 2009)
New Revision: 35

Modified:
   trunk/src/klog.cpp
   trunk/src/klog.ui
Log:
Connected slot to delete QSO's
Changed Save log to remove all the if statements. Makes the log file
bigger but makes saving quicker.

TODO
when there is only 1 QSO the deleteing it crashes KLOG