Re: [igraph] igraph 0.5.x visual studio 2005 'fixes'

[Gábor Csárdi]

Laurence, thanks for your efforts, I will look at the changes you
proposed, but probably only next week. The thing is that some of the
changes are not "correct", even if they make igraph compile. E.g. the
unistd.h trick is not good, we just need an empty unistd.h file or use
HAVE_UNISTD_H.  Then the import/export functions work properly.

I don't want to have #ifdef's for platforms, but rather for features.
The idea is to use configure to test for these features. I know that
you cannot use configure for VC++, so having a vc++.h file for VC++ is
possible, but then this vc++.h must just set the features correctly
instead of configure.

I kind of started this already:
http://bazaar.launchpad.net/~igraph/igraph/0.6-main/annotate/head%3A/msvc/include/config.h
So in the source files we just need to test these features instead of
testing _MSC_VER

Thanks again, I am sorry that it takes a long time to solve these issues, best,
Gabor

On Fri, Feb 20, 2009 at 1:52 PM, Tamas Nepusz <address@hidden> wrote:
>> In my previous mail I didn't described all changes though, so here is the
>> full list:
>
> I leave changes (1)-(3) to Gabor as he was the one who created the VC
> project file.
>
>> (4) inline issue
>> Proposed by Tamas:
>> Add this line:
>> #define inline __inline
>>
>> at the top of heap.c
>
> I think we should make it more sophisticated somehow, like:
>
> #ifdef _MSC_VER
> #define inline __inline
> #endif
>
> (not sure if _MSC_VER is the right way to identify MSVC++, though).
>
> Gabor, maybe it's time for a separate platform.h header to put all our
> platform and/or compiler specific hacks to?
>
>> The reason why VC++ complains about them:
>> "The inline keyword is available only in C++.
>
> The thing is that VC++ is wrong; inline is indeed part of the C99 standard
> (section 6.7.4, according to Wikipedia).
>
> --
> Tamas
>
>
> _______________________________________________
> igraph-help mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/igraph-help
>



-- 
Gabor Csardi <address@hidden>     UNIL DGM