Re: GNU Libtasn1 4.9 released

[Roman Bogorodskiy]

  Nikos Mavrogiannopoulos wrote:

> GNU Libtasn1 is a standalone library written in C for manipulating
> ASN.1 objects including DER/BER encoding/decoding.  GNU Libtasn1 is
> used by GnuTLS to handle X.509 structures and by GNU Shishi to handle
> Kerberos V5 structures.
> 
> * Noteworthy changes in release 4.9 (released 2016-07-25) [stable]
> - Fixes to OID encoding of OIDs which have elements which exceed 2^32

Hi,

With this release, I get the following build failure:


  CC       decoding.lo
decoding.c:121:12: error: comparison of integers of different signs: 'unsigned 
int' and 'int' [-Werror,-Wsign-compare]
              if (INT_MULTIPLY_OVERFLOW (ans, 256))
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gllib/intprops.h:302:3: note: expanded from macro 'INT_MULTIPLY_OVERFLOW'
  _GL_BINARY_OP_OVERFLOW (a, b, _GL_MULTIPLY_OVERFLOW)
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gllib/intprops.h:317:23: note: expanded from macro '_GL_BINARY_OP_OVERFLOW'
                      _GL_INT_MINIMUM (0 * (b) + (a)),          \
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gllib/intprops.h:80:8: note: expanded from macro '_GL_INT_MINIMUM'
   ? - _GL_INT_TWOS_COMPLEMENT (e) - _GL_SIGNED_INT_MAXIMUM (e)         \
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
./gllib/intprops.h:49:62: note: expanded from macro '_GL_INT_TWOS_COMPLEMENT'
#define _GL_INT_TWOS_COMPLEMENT(e) (~ _GL_INT_CONVERT (e, 0) == -1)
                                                             ^  ~~
./gllib/intprops.h:243:6: note: expanded from macro '_GL_MULTIPLY_OVERFLOW'
  (((min) == 0 && (((a) < 0 && 0 < (b)) || ((b) < 0 && 0 < (a))))       \
     ^~~

Full log is here: https://people.freebsd.org/~novel/misc/libtasn1_49.log

I'm using clang:

FreeBSD clang version 3.8.0 (tags/RELEASE_380/final 262564) (based on LLVM 
3.8.0)
Target: x86_64-unknown-freebsd11.0

Workaround is to configure with '--disable-gcc-warnings'. I' reporting this 
because:

1. --disable-gcc-warnings is not enabled by defualt
2. although the fix seems trivial, I'm not familiar with the code enough to be 
sure
   it won't break something import 

Roman Bogorodskiy

signature.asc
Description: PGP signature