Re: GNU Libtasn1 4.9 released

[Nikos Mavrogiannopoulos]

On Tue, Jul 26, 2016 at 2:12 AM, Roman Bogorodskiy
<address@hidden> wrote:
>   Nikos Mavrogiannopoulos wrote:
>> GNU Libtasn1 is a standalone library written in C for manipulating
>> ASN.1 objects including DER/BER encoding/decoding.  GNU Libtasn1 is
>> used by GnuTLS to handle X.509 structures and by GNU Shishi to handle
>> Kerberos V5 structures.
>>
>> * Noteworthy changes in release 4.9 (released 2016-07-25) [stable]
>> - Fixes to OID encoding of OIDs which have elements which exceed 2^32
> Hi,
>
> With this release, I get the following build failure:
>   CC       decoding.lo
> decoding.c:121:12: error: comparison of integers of different signs: 
> 'unsigned int' and 'int' [-Werror,-Wsign-compare]
>               if (INT_MULTIPLY_OVERFLOW (ans, 256))
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]
> Workaround is to configure with '--disable-gcc-warnings'. I' reporting this 
> because:
>
> 1. --disable-gcc-warnings is not enabled by defualt
> 2. although the fix seems trivial, I'm not familiar with the code enough to 
> be sure
>    it won't break something import

Right, -Werror shouldn't have been there. You can safely remove it or
configure with "--disable-gcc-warnings". The issue of this warnings
seems to be gnulib, and I'll update it on the master branch.

regards,
Nikos