help-gnats
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug in edit-pr.sh - missing quote


From: Mel Hatzis
Subject: bug in edit-pr.sh - missing quote
Date: Tue, 18 Feb 2003 15:11:59 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003

Please review the following patch to edit-pr.sh which fixes
a bug in edit-pr which shows up when an edit is attempted on
a PR that has missing Enum fields.

The bug is caused by a missing single quote. It results
in displaying warnings prior to the invocation of the editor
as well as missing the Enum field descriptions in the edit
template (for the missing Enum fields), when it occurs.

--
Mel Hatzis

Index: edit-pr.sh
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/edit-pr.sh,v
retrieving revision 1.16
diff -b -u -p -r1.16 edit-pr.sh
--- edit-pr.sh  26 May 2002 15:32:02 -0000      1.16
+++ edit-pr.sh  18 Feb 2003 23:05:40 -0000
@@ -169,7 +169,7 @@ do
            type="`$QUERY_PR --field-type $field`"
            case $type in
                [Ee][Nn][Uu][Mm])
-                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 
's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;`
+                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 
's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;'`
                    valslen=`echo "$values" | wc -c`
                    if [ "$valslen" -gt 160 ]
                    then





reply via email to

[Prev in Thread] Current Thread [Next in Thread]