help-gnats
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug setting EditUserEmailAddr for applyChangeActions


From: Mel Hatzis
Subject: bug setting EditUserEmailAddr for applyChangeActions
Date: Tue, 11 Feb 2003 16:35:53 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003

EditUserEmailAddr is not getting set correctly for applyChangeActions.
Instead of picking up the email address of the user doing the edit,
the $EditUserEmailAddr named parameter is getting set to the value
of the 'From' field in the PR header.

Any change-actions associated with a PR update that make use of the
$EditUserEmailAddr named parameter are likely doing something
unexpected.

Please review the following patch...

Index: file-pr.c
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/file-pr.c,v
retrieving revision 1.51
diff -u -p -r1.51 file-pr.c
--- file-pr.c   1 Nov 2002 11:37:51 -0000       1.51
+++ file-pr.c   12 Feb 2003 00:28:58 -0000
@@ -845,7 +845,7 @@ Date: %s\n\
   else
     {
       if (edit_field (pr->database, number, AUDIT_TRAIL (pr->database), 1,
-                     xstrdup (buf), NULL, header_value (pr, FROM), err)
+                     xstrdup (buf), NULL, from, err)
          == 0)
        {
          return 1;

--
Mel Hatzis





reply via email to

[Prev in Thread] Current Thread [Next in Thread]