[bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type.

[Dariqq]

Hi Ludo,

Thanks for the feedback. As this was pushed to master last week i am 
unsure how to incorporate it.

On 25.05.24 15:29, Ludovic Courtès wrote:
> Hi!
>
> Dariqq <dariqq@posteo.net> skribis:
>
> > * gnu/services/pm.scm
> > (power-profiles-configuration): New configuration.
> > (power-profiles-daemon-shepherd-service): New procedure.
> > (power-profiles-daemon-activation): New variable.
> > (power-profiles-daemon-service-type): New procedure.
> > * doc/guix.texi (Power Management Services): Document it.
> >
> > Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7
>
> […]
>
> > +@quotation Important
> > +The @code{power-profiles-daemon} conflicts with other power management tools
> > +like @code{tlp}. Using both together is not recommended.
>
> s/like/such as/
> s/Using.*/Pick one or the other./
>
> What about UPower?  Do I get it right that this actually builds upon
> UPower?

This comment is based on the information from 
https://gitlab.freedesktop.org/upower/power-profiles-daemon#conflicts. 
The systemd unit file specifies a conflict with tuned.service, 
tlp.service, auto-cpufreq.service and system76-power.service and I was 
not sure how to communicate this other with a big warning in the 
documentation.

Another option I thought about since then was to make p-p-d and tlp 
also provide a generic power-management name (suggestions for a better 
name are welcome) similiar to what is done with login-mangers providing 
xorg-server such that shepherd will not allow both at the same time.


> Should it say a word about how it defers from TLP?

Skimming through the tlp documentation 
(https://linrunner.de/tlp/faq/ppd.html) and the p-p-d README 
(https://gitlab.freedesktop.org/upower/power-profiles-daemon#why-not) 
main points seem to be:

- tlp is more customizable offering more (potentially destructive) 
options and fine-grained control
- p-p-d is more generic and with the integrations in DEs like GNOME, 
KDE, etc easier to use for normal desktop users.
> > +(define (power-profiles-daemon-shepherd-service config)
> > +  (match-record
> > +      config <power-profiles-daemon-configuration>
> > +      (power-profiles-daemon)
> > +    (list (shepherd-service (provision '(power-profiles-daemon))
> > +                           (requirement '(dbus-system))
>
> Rather: (requirement '(user-processes dbus-system)).
>
> > +                            (documentation "Run the power-profiles-daemon.")
>
> Nitpick: “Run the Power Profiles Daemon”.
>
> Also please indent this procedure similar to how this is done elsewhere.
>
> > +     (description "Run the power-profiles-daemon"))))
>
> Same as above.  :-)
>
> Thanks!
>
> Ludo’.