[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-serv
From: |
Ludovic Courtès |
Subject: |
[bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type. |
Date: |
Sat, 25 May 2024 15:29:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi!
Dariqq <dariqq@posteo.net> skribis:
> * gnu/services/pm.scm
> (power-profiles-configuration): New configuration.
> (power-profiles-daemon-shepherd-service): New procedure.
> (power-profiles-daemon-activation): New variable.
> (power-profiles-daemon-service-type): New procedure.
> * doc/guix.texi (Power Management Services): Document it.
>
> Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7
[…]
> +@quotation Important
> +The @code{power-profiles-daemon} conflicts with other power management tools
> +like @code{tlp}. Using both together is not recommended.
s/like/such as/
s/Using.*/Pick one or the other./
What about UPower? Do I get it right that this actually builds upon
UPower?
Should it say a word about how it defers from TLP?
> +(define (power-profiles-daemon-shepherd-service config)
> + (match-record
> + config <power-profiles-daemon-configuration>
> + (power-profiles-daemon)
> + (list (shepherd-service (provision '(power-profiles-daemon))
> + (requirement '(dbus-system))
Rather: (requirement '(user-processes dbus-system)).
> + (documentation "Run the power-profiles-daemon.")
Nitpick: “Run the Power Profiles Daemon”.
Also please indent this procedure similar to how this is done elsewhere.
> + (description "Run the power-profiles-daemon"))))
Same as above. :-)
Thanks!
Ludo’.
- [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it., Dariqq, 2024/05/02
- [bug#70460] [PATCH v2 2/3] gnu: power-profiles-daemon: Build gtk-docs., Dariqq, 2024/05/02
- [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type., Dariqq, 2024/05/02
- [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type.,
Ludovic Courtès <=
- [bug#70460] [PATCH v2 1/3] gnu: power-profiles-daemon: Update to 0.21., Dariqq, 2024/05/02
- [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it., Dariqq, 2024/05/09
- bug#70460: [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it., Christopher Baines, 2024/05/16