[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8
From: |
Saku Laesvuori |
Subject: |
[bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 |
Date: |
Fri, 21 Jul 2023 10:22:42 +0300 |
> > You would probably have to patch the `CMakeLists.txt` so it doesn't try
> > to build libsrtp from source, see what I did with crc32c in the
> > mentioned commit for reference. It is quite possible that telegram
> > doesn't actually need the source code and they are simply using a git
> > submodule to simplify their own dependency versioning and development.
> >
> > You might also have to add a new libsrtp version because the one
> > packaged in Guix is not configured to use openssl unlike telegram
> > expects. I'd still try the packaged version first if compiling telegram
> > a few more times isn't a big problem for you.
>
> I tried but didn't work, this change is similar to **libyuv**, that have
> reference to the source code of that external library: example
> https://github.com/desktop-app/tg_owt/blob/83-sdk/src/api/video/i010_buffer.cc#L17
>
> So the case of **libsrtp** is similar, check for example:
> -
> https://github.com/desktop-app/tg_owt/blob/master/src/pc/srtp_session_unittest.cc#L25
> -
> https://github.com/desktop-app/tg_owt/blob/master/src/pc/external_hmac.cc#L18
> - https://github.com/desktop-app/tg_owt/blob/master/src/pc/BUILD.gn#L174
>
> So change that will require patch several files, not just
> `CMakeLists.txt`, patch all those file will be make this package hard to
> maintain.
I see. I think libsrtp is small enough that unbundling it is not worth
the effort of patching all those files.
signature.asc
Description: PGP signature
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/20
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Saku Laesvuori, 2023/07/20
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/20
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Saku Laesvuori, 2023/07/20
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/20
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8,
Saku Laesvuori <=
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Raghav Gururajan, 2023/07/22
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Saku Laesvuori, 2023/07/22
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/24
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Raghav Gururajan, 2023/07/24
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Saku Laesvuori, 2023/07/26
- [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/26
[bug#64748] [PATCH v2] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/20
[bug#64748] [PATCH v3] gnu: webrtc-for-telegram-desktop: Update to a45d8b8, Distopico, 2023/07/26