[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify
From: |
Trev |
Subject: |
[bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify |
Date: |
Wed, 14 Sep 2022 09:28:32 -0700 |
User-agent: |
Notmuch/0.36 (https://notmuchmail.org) Emacs/28.1 (x86_64-pc-linux-gnu) |
Christopher Baines <mail@cbaines.net> writes:
>> ---
>> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>
> Hi Trevor,
>
> The commit message for adding a package like this one would generally
> look like:
>
> gnu: Add sbcl-stumpwm-notify.
>
> * gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable.
>
>
> You're mostly there.
>
Thank you for this feedback! I had been following the guidelines
described in the documentation:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
It states to write patches in the "changelog" format described here:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
Is there documentation somewhere that might help me adapt my strategy
for future contributions? I do prefer the tighter format you're asking
for :)
>> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
>> index 451dfce516..6ae0135a64 100644
>> --- a/gnu/packages/wm.scm
>> +++ b/gnu/packages/wm.scm
>> @@ -56,6 +56,7 @@
>> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> ;;; Copyright © 2022 muradm <mail@muradm.net>
>> ;;; Copyright © 2022 Elais Player <elais@fastmail.com>
>> +;;; Copyright © 2022 Trevor Richards <trev@trevdev.ca>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -2256,6 +2257,29 @@ (define-public sbcl-stumpwm-screenshot
>> PNG files.")
>> (license license:gpl3+)))
>>
>> +(define-public sbcl-stumpwm-notify
>> + (package
>> + (inherit stumpwm-contrib)
>> + (name "sbcl-stumpwm-notify")
>> + (build-system asdf-build-system/sbcl)
>> + (inputs
>> + `(("stumpwm" ,stumpwm "lib")
>> + ("xml-emitter" ,sbcl-xml-emitter)
>> + ("dbus" ,sbcl-dbus)
>> + ("bordeaux-threads" ,sbcl-bordeaux-threads)))
>> + (arguments
>> + '(#:asd-systems '("notify")
>> + #:tests? #f
>
> Why aren't the tests being run? If they can be run, that would be
> good. If there's a reason why they can't or shouldn't be run, it would
> be good to note that in a comment.
>
I flagged them off while testing the build in my own channel and forgot
to put them back on. Oops! They pass if they exist.
I can submit an update.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'chdir
>> + (lambda _ (chdir "util/notify") #t)))))
>> + (home-page "https://github.com/stumpwm/stumpwm-contrib")
>> + (synopsis "Notifications server for StumpWM")
>> + (description "Implements org.freedesktop.Notifications
>> +interface[fn:dbus-spec]. Shows notifications using stumpwm:message by
>> default.")
>> + (license license:gpl3)))
>> +
>> (define-public lemonbar
>> (package
>> (name "lemonbar")
>
--
Trev : 0FB7 D06B 4A2A F07E AD5B 1169 183B 6306 8AA1 D206