[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify
From: |
Christopher Baines |
Subject: |
[bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify |
Date: |
Wed, 14 Sep 2022 08:58:47 +0100 |
User-agent: |
mu4e 1.6.11; emacs 28.1 |
Trevor Richards <trev@trevdev.ca> writes:
> ---
> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Hi Trevor,
The commit message for adding a package like this one would generally
look like:
gnu: Add sbcl-stumpwm-notify.
* gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable.
You're mostly there.
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 451dfce516..6ae0135a64 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -56,6 +56,7 @@
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2022 muradm <mail@muradm.net>
> ;;; Copyright © 2022 Elais Player <elais@fastmail.com>
> +;;; Copyright © 2022 Trevor Richards <trev@trevdev.ca>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -2256,6 +2257,29 @@ (define-public sbcl-stumpwm-screenshot
> PNG files.")
> (license license:gpl3+)))
>
> +(define-public sbcl-stumpwm-notify
> + (package
> + (inherit stumpwm-contrib)
> + (name "sbcl-stumpwm-notify")
> + (build-system asdf-build-system/sbcl)
> + (inputs
> + `(("stumpwm" ,stumpwm "lib")
> + ("xml-emitter" ,sbcl-xml-emitter)
> + ("dbus" ,sbcl-dbus)
> + ("bordeaux-threads" ,sbcl-bordeaux-threads)))
> + (arguments
> + '(#:asd-systems '("notify")
> + #:tests? #f
Why aren't the tests being run? If they can be run, that would be
good. If there's a reason why they can't or shouldn't be run, it would
be good to note that in a comment.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'chdir
> + (lambda _ (chdir "util/notify") #t)))))
> + (home-page "https://github.com/stumpwm/stumpwm-contrib")
> + (synopsis "Notifications server for StumpWM")
> + (description "Implements org.freedesktop.Notifications
> +interface[fn:dbus-spec]. Shows notifications using stumpwm:message by
> default.")
> + (license license:gpl3)))
> +
> (define-public lemonbar
> (package
> (name "lemonbar")
signature.asc
Description: PGP signature