|
From: | Ludovic Courtès |
Subject: | [bug#41785] [PATCH v3 2/2] services: Add 'hurd-vm service-type'. |
Date: | Sat, 13 Jun 2020 16:35:04 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi, Mathieu Othacehe <othacehe@gnu.org> skribis: > +(define-syntax-rule (maybe-with-target image exp ...) > + (let ((target (image-target image))) > + (if target > + (with-parameters ((%current-target-system target)) > + exp ...) > + (begin > + exp ...)))) I think you don’t need the ‘if’ here. But then maybe you don’t need the macro either since you can always write: (with-parameters ((%current-target-system (image-target image))) …) Anyway, all this looks great to me! :-) Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |