[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic.
From: |
Jan Nieuwenhuizen |
Subject: |
[bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic. |
Date: |
Sat, 13 Jun 2020 15:05:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Mathieu Othacehe writes:
Hey Mathieu,
>> (system (current-system))
>> (target (operating-system-derivation target-os))
>> - (base-image (find-image
>> -
>> installation-disk-image-file-system-type))
>> + (base-image -> (find-image
>> +
>> installation-disk-image-file-system-type
>> + (%current-target-system)))
>
> This should be:
>
> (target (current-target-system))
> ...
> (base-image -> (find-image
> installation-disk-image-file-system-type
> target))
Ah, right. Done and moved this
>> (target (operating-system-derivation target-os))
down.
>> + ((image -> (find-image file-system-type (%current-target-system)))
>> (sys (system-derivation-for-action os image action
>> #:file-system-type
>> file-system-type
>> #:image-size image-size
>
> Same here, otherwise this look good to me.
Thanks! Pushed to master as 7ca533c7237622d70b423033c4506217d9ce4014
(probably/hopefully soon to be revisited by your image-catalog feature :-)
Greetings,
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com