[bug#41560] [PATCH 6/8] image: Use grub-efi to install the EFI bootloader.

[Mathieu Othacehe]

>>    "Install in ROOT directory, an EFI loader using BOOTLOADER-PACKAGE."
>> -  (install-efi-loader bootloader-package root))
>> +  (install-efi-loader grub-efi root))
>
> Does it have to be GRUB?

No any EFI compatible bootloader would do the trick. However, for now
"install-efi-loader" calls "grub-mkstandalone", so maybe we can keep it
that way for now?

>
>> +++ b/gnu/system/image.scm
>> @@ -235,6 +235,10 @@ used in the image."
>>                                #:references-graphs '#$graph
>>                                #:deduplicate? #f
>>                                #:system-directory #$os
>> +                              #:grub-efi #$(let-system (system target)
>> +                                             (and (target-intel?
>> +                                                   (or target system))
>> +                                                  grub-efi))
>
> Some AArch64 systems such as the SoftIron OverDrive 1000 use EFI too.
> So I don’t think the above is correct.

Yes you're correct. Actually, I think that I was overthinking this
thing. Using "#+grub-efi" should work.

>
>> +(define* (target-intel? #:optional (target (or (%current-target-system)
>> +                                               (%current-system))))
>> +  (any (cut string-prefix? <> target) '("x86_64" "i686")))
>
> Shouldn’t it include i[345]6 as well?

So I removed this bit.

>
> Also, I think no 32-bit Intel systems use EFI.
>
> Actually, why do we need to guess, can’t we just use the bootloader
> specified in the <operating-system> record?  (Naïve question, I haven’t
> checked…)

If we take the example of "installation-os", we use "grub-bootloader",
but we expect this image to be EFI ready. That's why "grub-efi" usage is
forced here.

As this is already the case without this serie, I think we can
proceed.

Thanks,

Mathieu