[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer'.
From: |
Mathieu Othacehe |
Subject: |
[bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer'. |
Date: |
Fri, 29 May 2020 09:17:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hey Ludo!
Thanks for the review :)
>> + (disk-image-installer bootloader-disk-image-installer
>> + (default #f))
>
> My only concern here is that we’re making an interface that’s only
> implemented by one bootloader, and I fear bitrot of the other
> bootloaders longer term. I guess we’ll see, this concern shouldn’t
> block progress.
I plan to implement it for extlinux and u-boot soon, so we should be
fine.
> Very smart. s/Grub/GRUB/ everywhere please. :-)
Yes, thank you :)
>
>> +(define (root-partition-index image)
>> + "Return the index of the root partition of the given IMAGE."
>> + (1+ (srfi-1:list-index identity
>> + (map root-partition? (image-partitions image)))))
>
> Isn’t it just (list-index root-partition (image-partitions image))?
Of course!
Mathieu
[bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer'., Ludovic Courtès, 2020/05/28
- [bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer'.,
Mathieu Othacehe <=
[bug#41560] [PATCH 0/8] image: Add MBR based boot support., Jan Nieuwenhuizen, 2020/05/27
[bug#41560] [PATCH 0/8] image: Add MBR based boot support., Ludovic Courtès, 2020/05/28