[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41179: [PATCH] gnu: Add ecm.
From: |
Kei |
Subject: |
bug#41179: [PATCH] gnu: Add ecm. |
Date: |
Wed, 13 May 2020 09:40:02 -0400 |
User-agent: |
Evolution 3.32.4 |
On Wed, 2020-05-13 at 11:21 +0200, Mathieu Othacehe wrote:
> Hello,
>
> > + (url "https://github.com/alucryd/ecm-tools")
> > + (commit (string-append "v" version))))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > + "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nn
> > b0c"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + '(#:tests? #f ; no check target
> > + #:make-flags (list "CC=gcc"
>
> Hard-coding CC breaks cross-compilation. See 'powerstat' package for
> how
> to fix it.
>
Thanks for the pointer! It's been fixed.
> > + (string-append "DESTDIR=" (assoc-ref
> > %outputs "out")))
> > + #:phases
> > + (modify-phases %standard-phases
> > + (replace 'configure
> > + (lambda _
> > + (substitute* "Makefile"
> > + (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> > + #t)))))
> > + (home-page "https://github.com/alucryd/ecm-tools")
> > + (synopsis "Error code modeler")
> > + (description "ECM is a utility that converts ECM files to BIN
> > CD format.")
> > + (license license:gpl3+)))
>
> Maybe you could elaborate a bit on what are ECM files.
>
Done!
> Otherwise, seems fine :)
>
> Thanks,
>
> Mathieu
Thanks for reviewing. This patch has been pushed to master as commit
3480ceb10a.
Kei