guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#41179] [PATCH] gnu: Add ecm.


From: Mathieu Othacehe
Subject: [bug#41179] [PATCH] gnu: Add ecm.
Date: Wed, 13 May 2020 11:21:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

> +                    (url "https://github.com/alucryd/ecm-tools";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nnb0c"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f                      ; no check target
> +       #:make-flags (list "CC=gcc"

Hard-coding CC breaks cross-compilation. See 'powerstat' package for how
to fix it.

> +                          (string-append "DESTDIR=" (assoc-ref %outputs 
> "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda _
> +             (substitute* "Makefile"
> +               (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> +             #t)))))
> +    (home-page "https://github.com/alucryd/ecm-tools";)
> +    (synopsis "Error code modeler")
> +    (description "ECM is a utility that converts ECM files to BIN CD 
> format.")
> +    (license license:gpl3+)))

Maybe you could elaborate a bit on what are ECM files.

Otherwise, seems fine :)

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]