[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools.
From: |
Danny Milosavljevic |
Subject: |
bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools. |
Date: |
Wed, 26 Apr 2017 19:15:49 +0200 |
On Wed, 26 Apr 2017 18:30:33 +0200
Thomas Danckaert <address@hidden> wrote:
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; We use sed --in-place because substitute* cannot handle the
> + ;; character encoding used by growisofs.c.
> + (system* "sed" "-i" "-e"
> + (string-append
> + "s,\"mkisofs\","
> + "\"" (assoc-ref inputs "cdrtools") "/bin/mkisofs\",")
> + "growisofs.c")
> + #t)))))
Maybe rather use
(zero? (system* ...))
instead of
(system* ...)
#t
Otherwise LGTM!
- bug#26669: [PATCH 1/7] gnu: Add cdrtools., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 5/7] gnu: Add wxwidgets-3.1., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 6/7] gnu: Add wxsvg., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 4/7] gnu: Add dvdauthor., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 7/7] gnu: Add dvdstyler., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 3/7] gnu: brasero: Embed growisofs store item., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools.,
Danny Milosavljevic <=
- bug#26669: [PATCH 1/7] gnu: Add cdrtools., Mathieu Othacehe, 2017/04/26