[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26669: [PATCH 1/7] gnu: Add cdrtools.
From: |
Mathieu Othacehe |
Subject: |
bug#26669: [PATCH 1/7] gnu: Add cdrtools. |
Date: |
Wed, 26 Apr 2017 18:59:53 +0200 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Hi Thomas,
Thanks for the patches !
Without going into details, it seems to me that you have indentation
issues in this serie.
> +(define-public cdrtools
> + (package
>From here indentation is broken.
> + (name "cdrtools")
> + (version "3.01")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://sourceforge/cdrtools/cdrtools-" version
> ".tar.bz2"))
> + (sha256
> + (base32
> + "03w6ypsmwwy4d7vh6zgwpc60v541vc5ywp8bdb758hbc4yv2wa7d"))
> + (patches (search-patches
> "cdrtools-3.01-mkisofs-isoinfo.patch"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("linux-headers" ,linux-libre-headers)))
> + (native-inputs
> + `(("coreutils" ,coreutils)))
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'set-linux-headers
> + (lambda _
> + (substitute* "autoconf/configure"
> + (("/usr/src/linux")
> + (assoc-ref %build-inputs "linux-headers")))
> + #t))
> + (add-before 'build 'substitute-dirs
> + (lambda _
> + (substitute* (append (find-files "DEFAULTS"
> "^Defaults\\.")
> + (find-files "DEFAULTS_ENG"
> "^Defaults\\.")
Please keep all lines in *.scm files to 80 columns or less.
> + (find-files "TEMPLATES"
> "^Defaults\\."))
> + (("/opt/schily") (assoc-ref %outputs "out")))
> + #t))
Thanks,
Mathieu
- bug#26669: [PATCH 1/7] gnu: Add cdrtools., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 5/7] gnu: Add wxwidgets-3.1., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 6/7] gnu: Add wxsvg., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 4/7] gnu: Add dvdauthor., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 7/7] gnu: Add dvdstyler., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 3/7] gnu: brasero: Embed growisofs store item., Thomas Danckaert, 2017/04/26
- bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools., Danny Milosavljevic, 2017/04/26
- bug#26669: [PATCH 1/7] gnu: Add cdrtools.,
Mathieu Othacehe <=