Re: broken "make dist" on core-updates-frozen

[Ludovic Courtès]

Hi!

Vagrant Cascadian <vagrant@debian.org> skribis:

> I've now pushed to core-updates-frozen:
>
>   
> https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates-frozen&id=6cdf4e5bf230fdbe17e592c2ec74fb34dba70eb5

Thanks!

>> I'll also make a plea to create a "make dist" job on ci.guix.gnu.org
>> soon, to catch these things earlier, as issues like this could block
>> making a release!
>
> Still think this would be a great idea! :)

Yes.  Note also that ‘guix lint -c patch-file-names’ also reports these:

--8<---------------cut here---------------start------------->8---
$ LANGUAGE= guix lint -c patch-file-names |grep "too long"
gnu/packages/admin.scm:2672:2: debops@1.1.0: 
debops-constants-for-external-program-names.patch: file name is too long
gnu/packages/astronomy.scm:768:2: xplanet@1.3.1: 
xplanet-1.3.1-libdisplay_DisplayOutput.cpp.patch: file name is too long
gnu/packages/astronomy.scm:768:2: xplanet@1.3.1: 
xplanet-1.3.1-xpUtil-Add2017LeapSecond.cpp.patch: file name is too long
gnu/packages/geo.scm:311:2: libgeotiff@1.5.1: 
libgeotiff-adapt-test-script-for-proj-6.2.patch: file name is too long
gnu/packages/glib.scm:478:2: gobject-introspection@1.62.0: 
gobject-introspection-absolute-shlib-path.patch: file name is too long
checking go-github-com-google-gmail-oauth2-tools-go-sendgmail@0.0.0-0.e322915 
[patch-file-names]..gnu/packages/java.scm:13120:2: java-apache-ivy@2.4.0: 
java-apache-ivy-port-to-latest-bouncycastle.patch: file name is too long
gnu/packages/java.scm:8926:2: 
java-tunnelvisionlabs-antlr4-runtime-annotations@4.7.4: 
java-tunnelvisionlabs-antlr-code-too-large.patch: file name is too long
gnu/packages/java.scm:9040:2: java-tunnelvisionlabs-antlr4@4.7.4: 
java-tunnelvisionlabs-antlr-code-too-large.patch: file name is too long
gnu/packages/java.scm:9032:2: java-tunnelvisionlabs-antlr4-runtime@4.7.4: 
java-tunnelvisionlabs-antlr-code-too-large.patch: file name is too long
gnu/packages/kde-frameworks.scm:3419:2: plasma-framework@5.70.1: 
plasma-framework-fix-KF5PlasmaMacros.cmake.patch: file name is too long
gnu/packages/llvm.scm:98:2: clang-runtime@3.9.1: 
clang-runtime-3.9-libsanitizer-mode-field.patch: file name is too long
gnu/packages/llvm.scm:98:2: clang-runtime@3.7.1: 
clang-runtime-3.8-libsanitizer-mode-field.patch: file name is too long
gnu/packages/llvm.scm:98:2: clang-runtime@3.8.1: 
clang-runtime-3.8-libsanitizer-mode-field.patch: file name is too long
gnu/packages/llvm.scm:851:4: clang-runtime@3.5.2: 
clang-runtime-3.5-libsanitizer-mode-field.patch: file name is too long
$ guix describe
Generacio 194   Nov 07 2021 23:40:30    (nuna)
  guix bd41e59
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: bd41e590dd24e54797fb8b6854c244efd4d12df5
--8<---------------cut here---------------end--------------->8---

It’s conservative so maybe not all these are problematic for “make
dist” (yet), but they’re worth fixing.

Ludo’.