guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Questionable "cosmetic changes" commits


From: Raghav Gururajan
Subject: Re: Questionable "cosmetic changes" commits
Date: Sun, 20 Dec 2020 06:55:44 +0000

Hi Chris!

> In the context of writing Guix packages, propagating the necessary
> inputs to support other packages finding the library via pkg-config is a
> serious thing, not trivial. If it breaks, dependent packages will likely
> change in behaviour or stop building entirely.

I understand. I didn't mean trivial as in importance but as in reason. Like 
most common reason why one propagates an input. :-)
 
> As for the comments, personally, I think the reasons behind propagated
> inputs are individual enough and important enough to each package that
> it's useful to write them down, even if that comment is "these things
> are referenced by the .pc file". That way others looking at the package
> definition don't have to wonder or try and dig through the Git history
> to find information about what's going on.

Agreed.

> Anyway, I think the most useful output from this discussion is amending
> or adding to the packaging guilelines to cover this:
> 
> https://guix.gnu.org/manual/en/html_node/Packaging-Guidelines.html

Yes, will be useful.

Regards,
RG.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]