Re: [OUTREACHY]: Integration of desktop environments into GNU Guix

[Danny Milosavljevic]

Hi RG,

pushed this patchset to wip-desktop with small changes.

I have the following comments/point out the following problems:

* gtksourceview depends on icedtea (Java) (because it has groovy as 
native-input),
which is not reproducible and only works on x86_64.  Please make it not depend 
on
icedtea.
  * So does tepl, because it depends on gtksourceview
* libsecret fails two tests

libsecret test failure:
 9/12 test-item                               FAIL     0.87 s (killed by signal 
11 SIGSEGV)
# GLib-DEBUG: posix_spawn avoided (workdir specified) (fd close requested) 
(child_setup specified) 
# GLib-DEBUG: setenv()/putenv() are not thread-safe and should not be used 
after threads are created
# GLib-DEBUG: unsetenv() is not thread-safe and should not be used after 
threads are created
[...]

 5/12 test-session                            FAIL     0.34 s (killed by signal 
5 SIGTRAP)
# GLib-DEBUG: setenv()/putenv() are not thread-safe and should not be used 
after threads are created
Bail out! GLib-FATAL-CRITICAL: g_source_ref: assertion 'g_atomic_int_get 
(&source->ref_count) >= 0' failed
--- stderr ---

(test-session:406): GLib-CRITICAL **: 22:02:56.436: g_source_ref: assertion 
'g_atomic_int_get (&source->ref_count) >= 0' failed

Both of those tests work fine outside nix build container and outside pure guix 
environment, while logged into X.

  * memphis doesn't build because of that
  * network-manager doesn't build because of that
  * gtksourceview doesn't build because of that
* gjs is not reproducible

gjs diffoscope:
├── bin
│ ├── .gjs-console-real
│ │ ├── readelf --wide --decompress --hex-dump=.data {}
│ │ │ @@ -51,15 +51,15 @@
│ │ │    0x0040a540 00000000 00000000 94ab4000 00000000 ..........@.....
│ │ │    0x0040a550 be714000 00000000 00000000 00000000 .q@.............
│ │ │    0x0040a560 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a570 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a580 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a590 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5a0 2a353741 00000000 00000000 00000000 *57A............
│ │ │ -  0x0040a5b0 f3a04bb6 00000000 30754000 00000000 ..K.....0u@.....
│ │ │ +  0x0040a5b0 48ed49b6 00000000 30754000 00000000 H.I.....0u@.....
│ │ │    0x0040a5c0 00474000 00000000 00000000 00000000 .G@.............
│ │ │    0x0040a5d0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5e0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a600 00000000 00000000 05000000 00000000 ................
│ │ │    0x0040a610 60a24000 00000000 00000000 00000000 `.@.............
│ │ │    0x0040a620 2a353741 00000000 00000000 00000000 *57A............
[...]
├── lib
│ ├── libgjs.so.0.0.0
│ │ ├── readelf --wide --decompress --hex-dump=.data {}
│ │ │ @@ -2687,15 +2687,15 @@
│ │ │    0x0049e4c0 a0223a00 00000000 00000000 00000000 .":.............
│ │ │    0x0049e4d0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0049e4e0 40203a00 00000000 0c000000 00000000 @ :.............
│ │ │    0x0049e4f0 40000000 00000000 2cca3a00 00000000 @.......,.:.....
│ │ │    0x0049e500 a0223a00 00000000 00000000 00000000 .":.............
│ │ │    0x0049e510 00000000 00000000 00000000 00000000 ................
│ │ │    0x0049e520 2a353741 00000000 00000000 00000000 *57A............
│ │ │ -  0x0049e530 e9a54bb6 00000000 00413a00 00000000 ..K......A:.....
│ │ │ +  0x0049e530 00f249b6 00000000 00413a00 00000000 ..I......A:.....

  * network-manager doesn't build reproducibly because of that, and doesn't 
build at all because of the libsecret test failures
    * network-manager-applet doesn't build reproducibly because of that
  * tracker doesn't build reproducibly because of that
    * tracker-miners doesn't build reproducibly because of that

Pushed your patches to wip-desktop anyway.

Please fix libsecret.

The other things are nice-to-have for now, but should also be fixed
eventually.

Did I apply all the patches you sent me or are some still pending?

pgpKneGYFhPQC.pgp
Description: OpenPGP digital signature