guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.


From: Jan Nieuwenhuizen
Subject: Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.
Date: Sun, 26 Apr 2020 21:09:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Ludovic Courtès writes:

>>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>>     
>>     * gnu/packages/package-management.scm (guix)[arguments]: When 
>> cross-compiling,
>>     skip copy-bootstrap-guile phase; needed for tests only.
...
>> -                    (add-before 'check 'copy-bootstrap-guile
>> +                    ,@(if (%current-target-system)
>> +                          '()
>> +                          `((add-before 'check 'copy-bootstrap-guile
>>                        (lambda* (#:key system inputs #:allow-other-keys)
>
> Perhaps it would be clearer by avoiding the unquote-splicing dance:
>
>   (lambda* (#:key system target inputs #:allow-other-keys)
>     (unless target
>       …)
>     #t)

Ah, yes.  No need to be careful not to trigger a rebuild.

> Otherwise LGTM!

Thanks, pushed to core-updates.
janneke

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]