Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.

[Ludovic Courtès]

Hi!

address@hidden skribis:

> commit f1bf6c5d7dfae3c1fc28e417c2f0940b0b010087
> Author: Jan (janneke) Nieuwenhuizen <address@hidden>
> AuthorDate: Fri Apr 24 08:54:43 2020 +0200
>
>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>     
>     * gnu/packages/package-management.scm (guix)[arguments]: When 
> cross-compiling,
>     skip copy-bootstrap-guile phase; needed for tests only.

[...]

> -                    (add-before 'check 'copy-bootstrap-guile
> +                    ,@(if (%current-target-system)
> +                          '()
> +                          `((add-before 'check 'copy-bootstrap-guile
>                        (lambda* (#:key system inputs #:allow-other-keys)

Perhaps it would be clearer by avoiding the unquote-splicing dance:

  (lambda* (#:key system target inputs #:allow-other-keys)
    (unless target
      …)
    #t)

Otherwise LGTM!

Ludo’.