guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: branch master updated: gnu: ode: Disable tests.


From: Ludovic Courtès
Subject: Re: branch master updated: gnu: ode: Disable tests.
Date: Tue, 28 Jan 2020 11:23:49 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi,

Nicolas Goaziou <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> What about disabling tests only on those platforms 
>
> I didn't realize that was possible. Hopefully, commit
> 5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this.

It does, thanks!  One minor issue:

+     ;; Tests fail on all systems but x86_64.
+     `(#:tests? ,(string=? "x86_64-linux"
+                           (or (%current-target-system)
+                               (%current-system)))

This should rather be:

  (string-prefix? "x86_64-" (or (%current-target-system) (%current-system)))

because ‘%current-target-system’ is a triplet (like “arm-linux-gnueabihf”)
whereas ‘%current-system’ is a “system type” (like “x86_64-linux”).

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]