Re: [PATCH 1/2] Support publishing build events

[Christopher Baines]

Ludovic Courtès <address@hidden> writes:

> Hi!
>
> Christopher Baines <address@hidden> skribis:
>
>>> IIUC, the ‘send-events’ program is provided as a debugging aid, right?
>>> I mean it’s not used anywhere in the code.
>>
>> Well, it would be potentially better to send the events from the same
>> Cuirass process that manages the builds, as then the events could be
>> sent out immediately.
>>
>> However, I don't really know how fibers work, so I went with a separate
>> process to make it easier to manually test, and to reduce any risk of
>> interfering with other Cuirass functions.
>
> Hmm, am I right that the ‘send-events’ program is not used at all by
> Cuirass itself?  Or did I overlook something?

You're right in that the send-events program isn't run by Cuirass, it's
another process that you'd run alongside the main Cuirass process.

> However, I saw a fiber of the main ‘cuirass’ process that calls the
> ‘send-events’ procedure, and to me it’s good this way.

Yeah, the process that takes care of performing the builds adds events,
and entries to the outbox table as well.

I'm still not sure if this is the ideal long term architecture, maybe
all the functionality should be handled in a single process. But for
now, I do think having a separate process makes this new events stuff
easier to test, and less likely to break other aspects of Cuirass.

Thanks,

Chris

signature.asc
Description: PGP signature