[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Support publishing build events
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/2] Support publishing build events |
Date: |
Sun, 17 Nov 2019 22:26:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Christopher Baines <address@hidden> skribis:
> I have access to bayfront already, so I think that's the place to try
> this out initially.
Sounds good.
>> IIUC, the ‘send-events’ program is provided as a debugging aid, right?
>> I mean it’s not used anywhere in the code.
>
> Well, it would be potentially better to send the events from the same
> Cuirass process that manages the builds, as then the events could be
> sent out immediately.
>
> However, I don't really know how fibers work, so I went with a separate
> process to make it easier to manually test, and to reduce any risk of
> interfering with other Cuirass functions.
Hmm, am I right that the ‘send-events’ program is not used at all by
Cuirass itself? Or did I overlook something?
However, I saw a fiber of the main ‘cuirass’ process that calls the
‘send-events’ procedure, and to me it’s good this way.
Thanks,
Ludo’.