guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."


From: Mark H Weaver
Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."
Date: Thu, 27 Jun 2019 01:52:37 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Tobias,

address@hidden writes:

> nckx pushed a commit to branch master
> in repository guix.
>
> commit 1ebb908d447fd7e641e800f970a0035ccd98deb7
> Author: Tobias Geerinckx-Rice <address@hidden>
> Date:   Thu Jun 27 00:20:50 2019 +0200
>
>     Revert "gnu: openssh: Clean-up custom install phase."
>
>     This reverts commit 7754136e464e02284624ad05c196d9ec26099143.

and you reverted another commit related to openssh as well:

> commit ba912479e8481d69b699ce348b35d5d70f0c9367
> Author: Tobias Geerinckx-Rice <address@hidden>
> Date:   Thu Jun 27 00:20:54 2019 +0200
>
>     Revert "gnu: openssh: Don't create the PRIVSEP_PATH directory."
>
>     This reverts commit 46475f72ab6127e7818fdea4a0ea9cc07c60a5f4.

I don't doubt that reverting these commits was the right thing to do,
but it would be good to know _why_ they were reverted.  Can you provide
a link to a relevant discussion, or else explain it here?

In general, when reverting commits, I think it would be useful to
include an explanation in the commit log.  What do you think?

    Regards,
      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]