Re: 01/01: guix: Simplify and robustify lzread!.

[Ludovic Courtès]

Hi Pierre,

Pierre Neidhardt <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> Hi Pierre!
>>
>> address@hidden skribis:
>>
>>> commit ecfc54403e2a1934b4f6e84ddad429b7970091fa
>>> Author: Pierre Neidhardt <address@hidden>
>>> Date:   Tue May 7 18:40:40 2019 +0200
>>>
>>>     guix: Simplify and robustify lzread!.
>>       ^
>> Should be lzlib.
>
> Oops!
> I must confess that I never really understood the whole logic behind
> GNU-style commit message :p

It’s really Guix-specific here, but the idea is that the word before
colon indicates the part of the code being modified, to provide a bit of
context.

>> Could you add a test for this corner case?  It’s corner cases like that
>> that can spoil the whole experience, so it feels safer to add tests as
>> soon as we encounter them.  :-)
>
> I would have, but I don't know how.  The problem is that I don't control
> the chunk size passed to the read! callback of the custom port.  That's
> all up to Guile's implementation of custom ports.
>
> In practice, it seems that the BV is always big enough so the potential
> issue can never arise.  But the new code is better on all aspects.

Didn’t you encounter the bug on an actual use case, though?  If you did,
you could just write that use case in the test file.  If not, that’s
okay.

(I’m super cautious here but that’s because I spent countless hours
debugging code that used zlib and libbz2 and lzo in the past.  :-))

Thanks,
Ludo’.