[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Status of Submitted Patches
From: |
Sahitihi |
Subject: |
Re: Status of Submitted Patches |
Date: |
Thu, 24 May 2018 22:46:19 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Hi Ricardo,
> Another note about style: I think it would be better to use
> “alist->hash-table” instead of “make-hash-table” followed by repeated
> modifications to the hash table with “hashq-set!”. We prefer to avoid
> mutation of values when possible.
I have made all necessary modifications. Can please review it once.
> Regarding copyright headers: please make sure to also add a copyright
> line for yourself and a copyright line from the file of guile-colorize
> to “(guix ui)”.
>
> When you’re done with these changes, please make a local commit and send
> the output of “git format-patch -1”.
I will proceed further once it is reviewed. :)
Thanks!!
---
Sahithi
term ansi-color.scm
Description: Text Data
- Re: Status of Submitted Patches, Sahithi Yarlagadda, 2018/05/11
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/11
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/12
- Re: Status of Submitted Patches, Sahitihi, 2018/05/15
- Re: Status of Submitted Patches, Sahitihi, 2018/05/23
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/25
- Re: Status of Submitted Patches,
Sahitihi <=
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/24
- Re: Status of Submitted Patches, Sahitihi, 2018/05/24
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/25
- Patch file for colorize module, Sahitihi, 2018/05/25
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Ricardo Wurmus, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Ricardo Wurmus, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26