[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/12] gnu: Add rust bootstrap binaries.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 07/12] gnu: Add rust bootstrap binaries. |
Date: |
Tue, 13 Dec 2016 23:44:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
David Craven <address@hidden> skribis:
> * gnu/packages/rust.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add rust.scm.
There are a couple of comments from
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00158.html>
that remain valid, I think. Could you double-check?
> +(define (system->rust-platform system)
> + (cond
> + ((string-prefix? "x86_64" system) "x86_64-unknown-linux-gnu")
> + ((string-prefix? "i686" system) "i686-unknown-linux-gnu")
> + (else #f)))
I think you can remove this procedure and use ‘nix-system->gnu-triplet’
instead.
> + (inputs
> + ;; FIXME: Use system gcc:lib. Does gcc "lib" need to be
> + ;; added to %final-inputs?
> + `(("gcc:lib" ,gcc "lib")
Use (canonical-package gcc).
> +(define-public rust-bootstrap
> + (package
> + (name "rust-bootstrap")
> + (version %rust-bootstrap-binaries-version)
> + (source #f)
> + (build-system trivial-build-system)
> + (propagated-inputs
> + ;; XXX: guix size shows a size of zero. Are propagated inputs not
> + ;; counted?
> + `(("rustc-bootstrap" ,rustc-bootstrap)
> + ("cargo-bootstrap" ,cargo-bootstrap)))
> + (arguments
> + `(#:builder
> + (begin (mkdir (assoc-ref %outputs "out")))))
> + (home-page "https://www.rust-lang.org")
> + (synopsis "Rust bootstrap")
“Rust bootstrapping meta-package”
OK with appropriate changes, thanks!
Ludo’.
- Re: [PATCH 05/12] import: Add updater for rust crates., (continued)
- [PATCH 06/12] gnu: llvm: Enable install utils., David Craven, 2016/12/11
- [PATCH 04/12] import: Add importer for rust crates., David Craven, 2016/12/11
- [PATCH 08/12] gnu: Add rustc., David Craven, 2016/12/11
- [PATCH 09/12] gnu: Add rust-libc., David Craven, 2016/12/11
- [PATCH 07/12] gnu: Add rust bootstrap binaries., David Craven, 2016/12/11
- Re: [PATCH 07/12] gnu: Add rust bootstrap binaries.,
Ludovic Courtès <=
- [PATCH 11/12] gnu: Add rust-rand., David Craven, 2016/12/11
- [PATCH 10/12] RECURSIVE IMPORTER wip, David Craven, 2016/12/11
- [PATCH 12/12] gnu: Add cargo., David Craven, 2016/12/11