[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add rofi.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add rofi. |
Date: |
Tue, 24 May 2016 23:38:00 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Tue, May 24, 2016 at 08:55:02AM +0200, Danny Milosavljevic wrote:
> On Mon, 23 May 2016 00:28:26 -0400
> Leo Famulari <address@hidden> wrote:
>
> > The failing test (helper_expand) seems to fail when it can't find
> > `which`.
>
> The failing test is test/helper-expand.c and it tries to do this:
>
> str = rofi_expand_path ( "~/" ); <----- oh oh
[...]
> str = rofi_expand_path ( "~root/" ); <--- oh oh
[...]
> str[i] = g_strdup ( g_get_home_dir () ); <----------- oh oh
[...]
> struct passwd *p = getpwnam ( &( str[i][1] ) ); <---------- oh oh
> What should we do about it?
How about disabling that test only? You can comment it out of wherever
it's invoked, or make it return true immediately. I'm not sure if we
have a canonical method... I think it depends on the language and
implementation.
- [PATCH] gnu: Add rofi., Danny Milosavljevic, 2016/05/20
- Re: [PATCH] gnu: Add rofi., Leo Famulari, 2016/05/23
- Re: [PATCH] gnu: Add rofi., Danny Milosavljevic, 2016/05/24
- Re: [PATCH] gnu: Add rofi.,
Leo Famulari <=
- [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable., Danny Milosavljevic, 2016/05/25
- Re: [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable., Leo Famulari, 2016/05/27
- [PATCH v3] gnu: Add rofi., Danny Milosavljevic, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Leo Famulari, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Danny Milosavljevic, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Leo Famulari, 2016/05/31